-
Notifications
You must be signed in to change notification settings - Fork 20
refactor: install tailwind and restyle most components #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restyles all welcome related components to Tailwind.
Member
Author
|
Note to self: Explore the use of canonical classes in Tailwind for M3 variables (like |
Member
Author
|
This should be good to go, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs Tailwind v4 and ports all main features and widgets to use Tailwind styling. All pages retain the same styling as before, with some enhancements to certain pages. The switch to Tailwind should significantly improve DX for future development, reduces the clutter and allows the removal of numerous
.cssfiles, removes many style classes that were defined but never used, and also reduce the CSS bundle size shipped to the client side.Other Notes:
<mat-pane>component will soon be marked as deprecated, as the nesting added ends up causing unfortunate effects on styling (often remedied only with::ng-deep, which is also now deprecated and bad practice). The pane effect can be created with<mat-card appearance="outlined" class="border-transparent!">. We may be able to makepanea directive in the future added to cards like so:<mat-card pane>.sharedand the signage feature have not been ported to Tailwind yet.styles.scssto be custom Tailwind styles.This PR resolves #819